Skip to content

Conversation

@abhilash1910
Copy link
Contributor

@abhilash1910 abhilash1910 requested a review from a team as a code owner November 6, 2024 14:18
Copy link
Contributor

@zhiweij1 zhiweij1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refine

Copy link
Contributor

@zhiweij1 zhiweij1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refine

@zhiweij1
Copy link
Contributor

Also could you please prepare an E2E test first? like https://github.com/oneapi-src/SYCLomatic-test/blob/SYCLomatic/features/feature_case/cublasLt/matmul.cu .
Make sure your test case (cuda code) can run pass on NV HW. Then migrate it to sycl. Compile the sycl code within your PR, make sure the result is same as the cuda code output.

@abhilash1910 abhilash1910 reopened this Nov 26, 2024
@abhilash1910 abhilash1910 changed the title [SYCLomatic] Enable migration of CUBLASLT_EPILOGUE_BIAS & CUBLASLT_EPILOGUE_GELU_AUX_BIAS [SYCLomatic] Enable migration of CUBLASLT: EPILOGUE_BIAS, EPILOGUE_GELU, EPILOGUE_GELU_AUX, EPILOGUE_GELU_AUX_BIAS Nov 29, 2024
@abhilash1910
Copy link
Contributor Author

Transfer to @zhiweij1 . Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants